[llvm] [BOLT] Report input staleness (PR #79496)
Amir Ayupov via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 25 12:41:37 PST 2024
https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/79496
None
>From 692fef3fb7b3fab4fc4c67412474576fdeba13b2 Mon Sep 17 00:00:00 2001
From: Amir Ayupov <aaupov at fb.com>
Date: Wed, 1 Nov 2023 14:44:55 -0700
Subject: [PATCH] [BOLT] Report input staleness
---
bolt/lib/Passes/BinaryPasses.cpp | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/bolt/lib/Passes/BinaryPasses.cpp b/bolt/lib/Passes/BinaryPasses.cpp
index 4e1343e2c30be5..955cd3726ad41a 100644
--- a/bolt/lib/Passes/BinaryPasses.cpp
+++ b/bolt/lib/Passes/BinaryPasses.cpp
@@ -1417,9 +1417,9 @@ void PrintProgramStats::runOnFunctions(BinaryContext &BC) {
<< (NumNonSimpleProfiledFunctions == 1 ? "" : "s")
<< " with profile could not be optimized\n";
}
- if (NumStaleProfileFunctions) {
+ if (NumAllStaleFunctions) {
const float PctStale =
- NumStaleProfileFunctions / (float)NumAllProfiledFunctions * 100.0f;
+ NumAllStaleFunctions / (float)NumAllProfiledFunctions * 100.0f;
auto printErrorOrWarning = [&]() {
if (PctStale > opts::StaleThreshold)
errs() << "BOLT-ERROR: ";
@@ -1427,16 +1427,18 @@ void PrintProgramStats::runOnFunctions(BinaryContext &BC) {
errs() << "BOLT-WARNING: ";
};
printErrorOrWarning();
- errs() << NumStaleProfileFunctions
+ errs() << NumAllStaleFunctions
<< format(" (%.1f%% of all profiled)", PctStale) << " function"
- << (NumStaleProfileFunctions == 1 ? "" : "s")
+ << (NumAllStaleFunctions == 1 ? "" : "s")
<< " have invalid (possibly stale) profile."
" Use -report-stale to see the list.\n";
if (TotalSampleCount > 0) {
printErrorOrWarning();
- errs() << StaleSampleCount << " out of " << TotalSampleCount
- << " samples in the binary ("
- << format("%.1f", ((100.0f * StaleSampleCount) / TotalSampleCount))
+ errs() << (StaleSampleCount + InferredSampleCount) << " out of "
+ << TotalSampleCount << " samples in the binary ("
+ << format("%.1f",
+ ((100.0f * (StaleSampleCount + InferredSampleCount)) /
+ TotalSampleCount))
<< "%) belong to functions with invalid"
" (possibly stale) profile.\n";
}
More information about the llvm-commits
mailing list