[llvm] f8262ca - [MemProf][NFC] remove unneeded sized memory access callback (#79260)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 24 18:01:20 PST 2024


Author: Enna1
Date: 2024-01-25T10:01:17+08:00
New Revision: f8262cae69a616b98774d4c669e11246fe3a9a05

URL: https://github.com/llvm/llvm-project/commit/f8262cae69a616b98774d4c669e11246fe3a9a05
DIFF: https://github.com/llvm/llvm-project/commit/f8262cae69a616b98774d4c669e11246fe3a9a05.diff

LOG: [MemProf][NFC] remove unneeded sized memory access callback (#79260)

As discussed in https://github.com/llvm/llvm-project/pull/79244, the
sized memory access callback is leftover stuff carried over from Asan,
can removed from the instrumentation.

Added: 
    

Modified: 
    llvm/lib/Transforms/Instrumentation/MemProfiler.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp b/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
index 57a89350a47b348..8cfcf11f80b0bb9 100644
--- a/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
+++ b/llvm/lib/Transforms/Instrumentation/MemProfiler.cpp
@@ -214,7 +214,6 @@ class MemProfiler {
 
   // These arrays is indexed by AccessIsWrite
   FunctionCallee MemProfMemoryAccessCallback[2];
-  FunctionCallee MemProfMemoryAccessCallbackSized[2];
 
   FunctionCallee MemProfMemmove, MemProfMemcpy, MemProfMemset;
   Value *DynamicShadowOffset = nullptr;
@@ -504,12 +503,7 @@ void MemProfiler::initializeCallbacks(Module &M) {
   for (size_t AccessIsWrite = 0; AccessIsWrite <= 1; AccessIsWrite++) {
     const std::string TypeStr = AccessIsWrite ? "store" : "load";
 
-    SmallVector<Type *, 3> Args2 = {IntptrTy, IntptrTy};
     SmallVector<Type *, 2> Args1{1, IntptrTy};
-    MemProfMemoryAccessCallbackSized[AccessIsWrite] =
-        M.getOrInsertFunction(ClMemoryAccessCallbackPrefix + TypeStr + "N",
-                              FunctionType::get(IRB.getVoidTy(), Args2, false));
-
     MemProfMemoryAccessCallback[AccessIsWrite] =
         M.getOrInsertFunction(ClMemoryAccessCallbackPrefix + TypeStr,
                               FunctionType::get(IRB.getVoidTy(), Args1, false));


        


More information about the llvm-commits mailing list