[llvm] [llvm-objdump][AMDGPU] Pass ELF ABIVersion through disassembler (PR #78907)
Konstantin Zhuravlyov via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 22 11:48:59 PST 2024
================
@@ -2184,8 +2188,7 @@ AMDGPUDisassembler::decodeKernelDescriptorDirective(
KERNEL_CODE_PROPERTY_ENABLE_WAVEFRONT_SIZE32);
}
- // FIXME: We should be looking at the ELF header ABI version for this.
- if (AMDGPU::getDefaultAMDHSACodeObjectVersion() >= AMDGPU::AMDHSA_COV5)
+ if (CodeObjectVersion >= AMDGPU::AMDHSA_COV5)
----------------
kzhuravl wrote:
What is the difference between AMDHSA_COV5 and ELFABIVERSION_AMDGPU_HSA_V5? Can't we use ELFABIVERSION_AMDGPU_HSA_V5 here?
https://github.com/llvm/llvm-project/pull/78907
More information about the llvm-commits
mailing list