[lld] fix test (PR #79018)

Vy Nguyen via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 10:13:35 PST 2024


================
@@ -2,7 +2,7 @@
 # RUN: mkdir -p %t
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s -o %t/hello.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o
-# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out
+# RUN: %lld -L %t %t/main.o -lhello.o -o %t/a.out
----------------
oontvoo wrote:

I think @smeenai was suggesting  sth like:

`%lld -lhello %t/main.o -o %t/a.out` (ie., using `-l<lib_name>` syntax - __without__ the `.o`). 

Perhaps for easy comparison, I'd suggest leaving your line #5  alone - and add an additional link that use the `-l<lib_name>` syntax - then smoke-check that the two output are the same.
(@smeenai thoughts?)

https://github.com/llvm/llvm-project/pull/79018


More information about the llvm-commits mailing list