[llvm] [AArch64] FP/SIMD is not mandatory for v8-R (PR #79004)

Simon Tatham via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 22 09:26:02 PST 2024


================
@@ -1420,7 +1420,8 @@ def ProcessorFeatures {
                                  FeaturePerfMon, FeatureSPE, FeatureSPE_EEF];
   list<SubtargetFeature> R82  = [HasV8_0rOps, FeaturePerfMon, FeatureFullFP16,
                                  FeatureFP16FML, FeatureSSBS, FeaturePredRes,
-                                 FeatureSB];
+                                 FeatureSB, FeatureRDM, FeatureDotProd,
+                                 FeatureComplxNum, FeatureJS];
----------------
statham-arm wrote:

The addition of `FeatureComplxNum` and `FeatureJS` here doesn't seem to have any relation to the commit message. I can see that you've removed `FeatureRDM` and `FeatureDotProd` from `HasV8_0rOps` and instead put them in `R82`, but there's no corresponding removal of these two anywhere else to match the addition of them here.

If that was intentional, can you add something to the commit message explaining why it was needed?

https://github.com/llvm/llvm-project/pull/79004


More information about the llvm-commits mailing list