[llvm] [InstrProf] Adding utility weights to BalancedPartitioning (PR #72717)

Fri Jan 19 14:04:04 PST 2024

dyung wrote:

Hi @spupyrev your change seems to cause a build bot failure on Windows, can you take a look?

https://lab.llvm.org/buildbot/#/builders/216/builds/33165
```
FAILED: unittests/ProfileData/CMakeFiles/ProfileDataTests.dir/BPFunctionNodeTest.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iunittests\ProfileData -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData -Iinclude -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\include -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\third-party\unittest\googletest\include -IZ:\b\llvm-clang-x86_64-sie-win\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /O2 /Ob2  -MD  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Founittests\ProfileData\CMakeFiles\ProfileDataTests.dir\BPFunctionNodeTest.cpp.obj /Fdunittests\ProfileData\CMakeFiles\ProfileDataTests.dir\ /FS -c Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(29): error C2665: 'std::forward': none of the 2 overloads could convert all the argument types
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\type_traits(1448): note: could be '_Ty &&std::forward<uint32_t>(unsigned int &&) noexcept'
        with
        [
            _Ty=uint32_t
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\type_traits(1442): note: or       '_Ty &&std::forward<uint32_t>(unsigned int &) noexcept'
        with
        [
            _Ty=uint32_t
        ]
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(27): note: while trying to match the argument list '(int)'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(44): note: see reference to function template instantiation 'auto llvm::BPFunctionNodeTest_Basic_Test::TestBody::<lambda_c7f27d8ac19ae610f12ac021b11cbf5c>::operator ()<int,int,int>(int,int,int) const' being compiled
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(28): error C2672: 'Field': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(27): error C2780: 'testing::PolymorphicMatcher<testing::internal::FieldMatcher<Class,FieldType>> testing::Field(const std::string &,FieldType Class::* ,const FieldMatcher &)': expects 3 arguments - 2 provided
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\third-party\unittest\googlemock\include\gmock/gmock-matchers.h(4431): note: see declaration of 'testing::Field'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(27): error C2784: 'testing::PolymorphicMatcher<testing::internal::FieldMatcher<Class,FieldType>> testing::Field(FieldType Class::* ,const FieldMatcher &)': could not deduce template argument for 'FieldType Class::* ' from 'const char [3]'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\third-party\unittest\googlemock\include\gmock/gmock-matchers.h(4418): note: see declaration of 'testing::Field'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(28): error C2672: 'testing::UnorderedElementsAre': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(41): error C2664: 'testing::internal::VariadicMatcher<testing::internal::AllOfMatcherImpl,testing::PolymorphicMatcher<testing::internal::FieldMatcher<llvm::BPFunctionNode,llvm::BPFunctionNode::IDT>>,testing::PolymorphicMatcher<testing::internal::FieldMatcher<llvm::BPFunctionNode,llvm::SmallVector<llvm::BPFunctionNode::UtilityNodeT,4>>>> llvm::BPFunctionNodeTest_Basic_Test::TestBody::<lambda_eb0144a4e20c49d4d4e5be57dd13cd92>::operator ()(llvm::BPFunctionNode::IDT,testing::Matcher<llvm::ArrayRef<llvm::BPFunctionNode::UtilityNodeT>>) const': cannot convert argument 2 from 'void' to 'testing::Matcher<llvm::ArrayRef<llvm::BPFunctionNode::UtilityNodeT>>'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(41): note: Expressions of type void cannot be converted to other types
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(36): note: see declaration of 'llvm::BPFunctionNodeTest_Basic_Test::TestBody::<lambda_eb0144a4e20c49d4d4e5be57dd13cd92>::operator ()'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(41): error C2672: 'testing::UnorderedElementsAre': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(41): error C2672: 'testing::internal::MakePredicateFormatterFromMatcher': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(41): error C2737: 'gtest_ar': const object must be initialized
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(51): error C2664: 'testing::internal::VariadicMatcher<testing::internal::AllOfMatcherImpl,testing::PolymorphicMatcher<testing::internal::FieldMatcher<llvm::BPFunctionNode,llvm::BPFunctionNode::IDT>>,testing::PolymorphicMatcher<testing::internal::FieldMatcher<llvm::BPFunctionNode,llvm::SmallVector<llvm::BPFunctionNode::UtilityNodeT,4>>>> llvm::BPFunctionNodeTest_Basic_Test::TestBody::<lambda_eb0144a4e20c49d4d4e5be57dd13cd92>::operator ()(llvm::BPFunctionNode::IDT,testing::Matcher<llvm::ArrayRef<llvm::BPFunctionNode::UtilityNodeT>>) const': cannot convert argument 2 from 'void' to 'testing::Matcher<llvm::ArrayRef<llvm::BPFunctionNode::UtilityNodeT>>'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(51): note: Expressions of type void cannot be converted to other types
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(36): note: see declaration of 'llvm::BPFunctionNodeTest_Basic_Test::TestBody::<lambda_eb0144a4e20c49d4d4e5be57dd13cd92>::operator ()'
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(51): error C2672: 'testing::UnorderedElementsAre': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(51): error C2672: 'testing::internal::MakePredicateFormatterFromMatcher': no matching overloaded function found
Z:\b\llvm-clang-x86_64-sie-win\llvm-project\llvm\unittests\ProfileData\BPFunctionNodeTest.cpp(51): error C2737: 'gtest_ar': const object must be initialized

```

https://github.com/llvm/llvm-project/pull/72717