[llvm] [AMDGPU] Update isLegalAddressingMode for GFX12 SMEM loads (PR #78728)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 19 07:29:17 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Jay Foad (jayfoad)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/78728.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIISelLowering.cpp (+8-7)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 929b5d004782d3..bdb617e7d3450b 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -1525,13 +1525,14 @@ bool SITargetLowering::isLegalAddressingMode(const DataLayout &DL,
if (AM.BaseOffs % 4 != 0)
return isLegalMUBUFAddressingMode(AM);
- // There are no SMRD extloads, so if we have to do a small type access we
- // will use a MUBUF load.
- // FIXME?: We also need to do this if unaligned, but we don't know the
- // alignment here.
- // TODO: Update this for GFX12 which does have scalar sub-dword loads.
- if (Ty->isSized() && DL.getTypeStoreSize(Ty) < 4)
- return isLegalGlobalAddressingMode(AM);
+ if (!Subtarget->hasScalarSubwordLoads()) {
+ // There are no SMRD extloads, so if we have to do a small type access we
+ // will use a MUBUF load.
+ // FIXME?: We also need to do this if unaligned, but we don't know the
+ // alignment here.
+ if (Ty->isSized() && DL.getTypeStoreSize(Ty) < 4)
+ return isLegalGlobalAddressingMode(AM);
+ }
if (Subtarget->getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) {
// SMRD instructions have an 8-bit, dword offset on SI.
``````````
</details>
https://github.com/llvm/llvm-project/pull/78728
More information about the llvm-commits
mailing list