[libcxx] [llvm] [lldb] [compiler-rt] [lld] [lld-macho] Find objects in library search path (PR #78628)

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 17:43:12 PST 2024


================
@@ -95,11 +95,16 @@ static std::optional<StringRef> findLibrary(StringRef name) {
               findPathCombination("lib" + name, config->librarySearchPaths,
                                   {".tbd", ".dylib", ".so"}))
         return path;
-      return findPathCombination("lib" + name, config->librarySearchPaths,
-                                 {".a"});
+      else if (std::optional<StringRef> path = findPathCombination(
+                   "lib" + name, config->librarySearchPaths, {".a"}))
+        return path;
+      return findPathCombination(name, config->librarySearchPaths, {""});
----------------
smeenai wrote:

Hmm. In that case, we probably want to instead change `findPathCombination` to take a list of prefixes, so that we can match ld64's search behavior?

https://github.com/llvm/llvm-project/pull/78628


More information about the llvm-commits mailing list