[llvm] [MemProf] Don't skip direct recursion in function summary (PR #78264)
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 18 14:21:33 PST 2024
teresajohnson wrote:
> I'm not sure why we treat direct recursion specially. Why don't we treat all recursion in the same way?For example: foo->foo->foo foo->bar->foo->bar
At the time I was thinking that it is a little easier to get the direct recursion case right in some simple cases, but I'm not sure this is the right way to handle it as I think through it again now. We should probably treat them the same, which I think this change will essentially do (see my reply on discourse, I think we should be handling recursion detected in the thin link conservatively).
Can you attach a test case?
https://github.com/llvm/llvm-project/pull/78264
More information about the llvm-commits
mailing list