[llvm] [Coroutines] Fix inline comment about frame layout (PR #78626)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 13:19:57 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-coroutines

Author: None (yonillasky)

<details>
<summary>Changes</summary>

`ResumeIndex` isn't part of the frame struct header, so it necessarily appears after the promise.


---
Full diff: https://github.com/llvm/llvm-project/pull/78626.diff


1 Files Affected:

- (modified) llvm/lib/Transforms/Coroutines/CoroFrame.cpp (+1-1) 


``````````diff
diff --git a/llvm/lib/Transforms/Coroutines/CoroFrame.cpp b/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
index 429344652a4c49..db09337215c10f 100644
--- a/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
+++ b/llvm/lib/Transforms/Coroutines/CoroFrame.cpp
@@ -1289,8 +1289,8 @@ static void buildFrameDebugInfo(Function &F, coro::Shape &Shape,
 //   struct f.frame {
 //     ResumeFnTy ResumeFnAddr;
 //     ResumeFnTy DestroyFnAddr;
-//     int ResumeIndex;
 //     ... promise (if present) ...
+//     int ResumeIndex;
 //     ... spills ...
 //   };
 static StructType *buildFrameType(Function &F, coro::Shape &Shape,

``````````

</details>


https://github.com/llvm/llvm-project/pull/78626


More information about the llvm-commits mailing list