[llvm] [FileCheck]: Fix diagnostics for NOT prefixes (PR #78412)

Vinayak Dev via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 18 08:56:13 PST 2024


vinayakdsci wrote:

@RoboTux I apologise, but I am a tad bit confused what you mean when you say that I would want to modify printMatch and printNotMatch to handle CheckNot.

Do you mean I need to modify their definitions? I could simply pass in the correct prefix through reportMatchResult being called in CheckDag() and CheckNot(); Wouldn't that make it immaterial what Prefix is exactly held at CheckStr.Check(), if the current prefix is a DAG or NOT string?

All other suggestions you gave I have already incorporated, and been able to get all tests to pass satisfactorily.

Thanks a lot!

https://github.com/llvm/llvm-project/pull/78412


More information about the llvm-commits mailing list