[llvm] [XCOFF][obj2yaml] Support SymbolAlignmentAndType as 2 separate fields in YAML. (PR #76828)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 18 00:49:02 PST 2024
================
@@ -37,7 +37,7 @@ class XCOFFDumper {
Error dumpAuxSyms(XCOFFYAML::Symbol &Sym, const XCOFFSymbolRef &SymbolEntRef);
void dumpFuncAuxSym(XCOFFYAML::Symbol &Sym, const uintptr_t AuxAddress);
void dumpExpAuxSym(XCOFFYAML::Symbol &Sym, const uintptr_t AuxAddress);
- void dumpCscetAuxSym(XCOFFYAML::Symbol &Sym,
+ void dumpCsectAuxSym(XCOFFYAML::Symbol &Sym,
----------------
jh7370 wrote:
I couldn't find an exact reference from the community guidelines, but it's strongly related to this part of the "How to submit a patch" section describing what a patch must be:
> be an isolated change. Independent changes should be submitted as separate patches as this makes reviewing easier.
The norm is to do the nfc fix immediately before landing the real patch.
https://github.com/llvm/llvm-project/pull/76828
More information about the llvm-commits
mailing list