[llvm] [Xtensa] Initial support of the ALU operations and ConstantPool (PR #78548)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 17 23:53:13 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff f01b6ca8bed49bdb957607456aed29ff8ee97109 6f375b3c1bfcefdb8fe217efa381bf2cf8f757d3 -- llvm/lib/Target/Xtensa/MCTargetDesc/XtensaTargetStreamer.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaTargetStreamer.h llvm/lib/Target/Xtensa/Xtensa.h llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp llvm/lib/Target/Xtensa/XtensaAsmPrinter.h llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h llvm/lib/Target/Xtensa/XtensaFrameLowering.cpp llvm/lib/Target/Xtensa/XtensaFrameLowering.h llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp llvm/lib/Target/Xtensa/XtensaISelLowering.cpp llvm/lib/Target/Xtensa/XtensaISelLowering.h llvm/lib/Target/Xtensa/XtensaInstrInfo.cpp llvm/lib/Target/Xtensa/XtensaInstrInfo.h llvm/lib/Target/Xtensa/XtensaMCInstLower.cpp llvm/lib/Target/Xtensa/XtensaMCInstLower.h llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp llvm/lib/Target/Xtensa/XtensaRegisterInfo.h llvm/lib/Target/Xtensa/XtensaSubtarget.cpp llvm/lib/Target/Xtensa/XtensaSubtarget.h llvm/lib/Target/Xtensa/XtensaUtils.cpp llvm/lib/Target/Xtensa/XtensaUtils.h llvm/lib/Target/Xtensa/AsmParser/XtensaAsmParser.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaAsmBackend.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaInstPrinter.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCCodeEmitter.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCExpr.cpp llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp llvm/lib/Target/Xtensa/XtensaTargetMachine.h
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp b/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
index 8914ebf658..87ef66ba74 100644
--- a/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
+++ b/llvm/lib/Target/Xtensa/MCTargetDesc/XtensaMCTargetDesc.cpp
@@ -8,10 +8,10 @@
//
//===----------------------------------------------------------------------===//
#include "XtensaMCTargetDesc.h"
+#include "TargetInfo/XtensaTargetInfo.h"
#include "XtensaInstPrinter.h"
#include "XtensaMCAsmInfo.h"
#include "XtensaTargetStreamer.h"
-#include "TargetInfo/XtensaTargetInfo.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/MC/MCAsmInfo.h"
#include "llvm/MC/MCInstrInfo.h"
diff --git a/llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp b/llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp
index cf770ca289..312bcbb13e 100644
--- a/llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaAsmPrinter.cpp
@@ -14,8 +14,8 @@
//===----------------------------------------------------------------------===//
#include "XtensaAsmPrinter.h"
-#include "XtensaConstantPoolValue.h"
#include "TargetInfo/XtensaTargetInfo.h"
+#include "XtensaConstantPoolValue.h"
#include "XtensaMCInstLower.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/BinaryFormat/ELF.h"
diff --git a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
index 2845a5ac84..f286a8a9e8 100644
--- a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.cpp
@@ -74,8 +74,7 @@ void XtensaConstantPoolValue::print(raw_ostream &O) const {}
XtensaConstantPoolConstant::XtensaConstantPoolConstant(
const Constant *C, unsigned ID, XtensaCP::XtensaCPKind Kind)
- : XtensaConstantPoolValue((Type *)C->getType(), ID, Kind),
- CVal(C) {}
+ : XtensaConstantPoolValue((Type *)C->getType(), ID, Kind), CVal(C) {}
XtensaConstantPoolConstant *
XtensaConstantPoolConstant::Create(const Constant *C, unsigned ID,
@@ -149,8 +148,7 @@ void XtensaConstantPoolSymbol::print(raw_ostream &O) const {
XtensaConstantPoolMBB::XtensaConstantPoolMBB(LLVMContext &C,
const MachineBasicBlock *mbb,
unsigned id)
- : XtensaConstantPoolValue(C, 0, XtensaCP::CPMachineBasicBlock),
- MBB(mbb) {}
+ : XtensaConstantPoolValue(C, 0, XtensaCP::CPMachineBasicBlock), MBB(mbb) {}
XtensaConstantPoolMBB *
XtensaConstantPoolMBB::Create(LLVMContext &C, const MachineBasicBlock *mbb,
@@ -207,4 +205,3 @@ void XtensaConstantPoolJumpTable::print(raw_ostream &O) const {
O << "JT" << IDX;
XtensaConstantPoolValue::print(O);
}
-
diff --git a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
index 9aaf9776fe..f7606300ed 100644
--- a/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
+++ b/llvm/lib/Target/Xtensa/XtensaConstantPoolValue.h
@@ -50,7 +50,7 @@ enum XtensaCPModifier {
class XtensaConstantPoolValue : public MachineConstantPoolValue {
unsigned LabelId; // Label id of the load.
XtensaCP::XtensaCPKind Kind; // Kind of constant.
- XtensaCP::XtensaCPModifier Modifier; // Symbol name modifier
+ XtensaCP::XtensaCPModifier Modifier; // Symbol name modifier
//(for example Global Variable name)
protected:
@@ -156,7 +156,6 @@ public:
}
};
-
/// XtensaConstantPoolSymbol - Xtensa-specific constantpool values for external
/// symbols.
class XtensaConstantPoolSymbol : public XtensaConstantPoolValue {
diff --git a/llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp b/llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp
index b46f03b32e..5dce84c89a 100644
--- a/llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaISelDAGToDAG.cpp
@@ -54,8 +54,7 @@ public:
}
if (TM.isPositionIndependent()) {
- DiagnosticInfoUnsupported Diag(
- CurDAG->getMachineFunction().getFunction(),
+ DiagnosticInfoUnsupported Diag(CurDAG->getMachineFunction().getFunction(),
"PIC relocations are not supported ",
Addr.getDebugLoc());
CurDAG->getContext()->diagnose(Diag);
diff --git a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
index acf0cdaff7..e20afa68d2 100644
--- a/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaISelLowering.cpp
@@ -13,8 +13,8 @@
//
//===----------------------------------------------------------------------===//
-#include "XtensaConstantPoolValue.h"
#include "XtensaISelLowering.h"
+#include "XtensaConstantPoolValue.h"
#include "XtensaSubtarget.h"
#include "XtensaTargetMachine.h"
#include "llvm/CodeGen/CallingConvLower.h"
@@ -352,8 +352,8 @@ SDValue XtensaTargetLowering::LowerImmediate(SDValue Op,
return Op;
}
-SDValue XtensaTargetLowering::LowerImmediateFP(SDValue Op, SelectionDAG & DAG)
- const {
+SDValue XtensaTargetLowering::LowerImmediateFP(SDValue Op,
+ SelectionDAG &DAG) const {
if (Op.getValueType() != MVT::f32)
return Op;
const ConstantFPSDNode *CN = cast<ConstantFPSDNode>(Op);
diff --git a/llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp b/llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp
index a218af8c4d..754bd4671a 100644
--- a/llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaRegisterInfo.cpp
@@ -106,9 +106,9 @@ bool XtensaRegisterInfo::eliminateFrameIndex(MachineBasicBlock::iterator II,
int FrameIndex = MI.getOperand(FIOperandNum).getIndex();
uint64_t stackSize = MF.getFrameInfo().getStackSize();
int64_t spOffset = MF.getFrameInfo().getObjectOffset(FrameIndex);
- LLVM_DEBUG(errs() << "FrameIndex : " << FrameIndex << "\n"
- << "spOffset : " << spOffset << "\n"
- << "stackSize : " << stackSize << "\n");
+ LLVM_DEBUG(errs() << "FrameIndex : " << FrameIndex << "\n"
+ << "spOffset : " << spOffset << "\n"
+ << "stackSize : " << stackSize << "\n");
return eliminateFI(MI, FIOperandNum, FrameIndex, stackSize, spOffset);
}
diff --git a/llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp b/llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp
index d61533e0c4..5ee24c701f 100644
--- a/llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp
+++ b/llvm/lib/Target/Xtensa/XtensaTargetMachine.cpp
@@ -78,7 +78,7 @@ public:
: TargetPassConfig(TM, PM) {}
XtensaTargetMachine &getXtensaTargetMachine() const {
- return getTM<XtensaTargetMachine>();
+ return getTM<XtensaTargetMachine>();
}
bool addInstSelector() override;
``````````
</details>
https://github.com/llvm/llvm-project/pull/78548
More information about the llvm-commits
mailing list