[compiler-rt] 63a3c4c - [compiler-rt] Silence warning with MSVC 19.38 (Visual Studio 2022 17.8.3)

Alexandre Ganea via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 04:24:06 PST 2024


Author: Alexandre Ganea
Date: 2024-01-17T07:23:56-05:00
New Revision: 63a3c4cc85066a5fc44ae7f55d5b42a5708b9724

URL: https://github.com/llvm/llvm-project/commit/63a3c4cc85066a5fc44ae7f55d5b42a5708b9724
DIFF: https://github.com/llvm/llvm-project/commit/63a3c4cc85066a5fc44ae7f55d5b42a5708b9724.diff

LOG: [compiler-rt] Silence warning with MSVC 19.38 (Visual Studio 2022 17.8.3)

This fixes:
```
C:\git\llvm-project\compiler-rt\lib\orc\coff_platform.cpp(512): warning C4189: 'JDState': local variable is initialized but not referenced
```

Added: 
    

Modified: 
    compiler-rt/lib/orc/coff_platform.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/orc/coff_platform.cpp b/compiler-rt/lib/orc/coff_platform.cpp
index 78c86c855dcb29..9fe5c0b062897b 100644
--- a/compiler-rt/lib/orc/coff_platform.cpp
+++ b/compiler-rt/lib/orc/coff_platform.cpp
@@ -509,7 +509,6 @@ Error COFFPlatformRuntimeState::deregisterObjectSections(
               << HeaderAddr.getValue();
     return make_error<StringError>(ErrStream.str());
   }
-  auto &JDState = I->second;
   for (auto &KV : Secs) {
     if (auto Err = deregisterBlockRange(HeaderAddr, KV.second))
       return Err;
@@ -687,7 +686,14 @@ struct ThrowInfo {
 
 ORC_RT_INTERFACE void __stdcall __orc_rt_coff_cxx_throw_exception(
     void *pExceptionObject, ThrowInfo *pThrowInfo) {
+#ifdef __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wmultichar"
+#endif
   constexpr uint32_t EH_EXCEPTION_NUMBER = 'msc' | 0xE0000000;
+#ifdef __clang__
+#pragma clang diagnostic pop
+#endif
   constexpr uint32_t EH_MAGIC_NUMBER1 = 0x19930520;
   auto BaseAddr = COFFPlatformRuntimeState::get().findJITDylibBaseByPC(
       reinterpret_cast<uint64_t>(pThrowInfo));


        


More information about the llvm-commits mailing list