[llvm] [indvars] Missing variables at Og: (PR #69920)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 17 03:30:15 PST 2024


================
@@ -468,6 +468,13 @@ int rewriteLoopExitValues(Loop *L, LoopInfo *LI, TargetLibraryInfo *TLI,
                           ReplaceExitVal ReplaceExitValue,
                           SmallVector<WeakTrackingVH, 16> &DeadInsts);
 
+/// Assign exit values to variables that use this loop variable during the loop.
----------------
jmorse wrote:

I think for a few of these function signatures it won't be obvious to the reader how to use them -- could you elaborate the documentation a little, I reckon it only needs a sentence for each function, but the sentences need to refer to the arguments. See the documentation for `setProfileInfoAfterUnrolling` below for inspiration, something like "For variable-users of \p IndVar create assignments in \p Successor of the exit value \p PN" or similar.

https://github.com/llvm/llvm-project/pull/69920


More information about the llvm-commits mailing list