[llvm] [TLI] Fix replace-with-veclib crash with invalid arguments (PR #77112)

[Paschalis Mpeis via llvm-commits]

paschalis-mpeis wrote:

Hi Pranav,

It looks like my patch is not related to the test in question.
Yes, it did pass all lit and unit tests. See also an output at the end of this email.

Please note that another patch was breaking a handful of tests yesterday, and this one was caught between that patch and its reversion.

Please let me know if you still have this issue as it seems I cannot find your comment online.

Regards,
Paschalis

$ ninja -C $build AnalysisTests && $build/unittests/Analysis/AnalysisTests --gtest_filter="ConstraintSolverTest*"
Note: Google Test filter = ConstraintSolverTest*
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from ConstraintSolverTest
[ RUN      ] ConstraintSolverTest.TestSolutionChecks
[       OK ] ConstraintSolverTest.TestSolutionChecks (0 ms)
[ RUN      ] ConstraintSolverTest.IsConditionImplied
[       OK ] ConstraintSolverTest.IsConditionImplied (0 ms)
[ RUN      ] ConstraintSolverTest.IsConditionImpliedOverflow
[       OK ] ConstraintSolverTest.IsConditionImpliedOverflow (0 ms)
[----------] 3 tests from ConstraintSolverTest (0 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 3 tests.


From: Pranav Kant ***@***.***>
Date: Tuesday, 16 January 2024 at 18:57
To: llvm/llvm-project ***@***.***>
Cc: Paschalis Mpeis ***@***.***>, State change ***@***.***>
Subject: Re: [llvm/llvm-project] [TLI] Fix replace-with-veclib crash with invalid arguments (PR #77112)

Hmm, my internal bisect suggests that this commit seems to fail llvm/unittests/Analysis/ConstraintSystemTest.cpp
Have you verified that it isn't regressing this after your commit?

—
Reply to this email directly, view it on GitHub<https://github.com/llvm/llvm-project/pull/77112#issuecomment-1894336602>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJWK7ALBSH6DB24WPDGBGLYO3EPTAVCNFSM6AAAAABBOTRJFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGMZTMNRQGI>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


https://github.com/llvm/llvm-project/pull/77112