[llvm] On Windows, make the release script work with the local git checkout (PR #78273)

Alexandre Ganea via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 06:23:50 PST 2024


================
@@ -106,8 +108,8 @@ echo Using VS devcmd: %vsdevcmd%
 :: start echoing what we do
 @echo on
 
-set python32_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python310-32
-set python64_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python310
+set python32_dir=C:\Users\%USERNAME%\AppData\Local\Programs\Python\Python311-32
----------------
aganea wrote:

> LLDB is super fiddly about the Python stuff, and it's great at finding the versions on my system which don't work. It's also important that the version used in the package is consistent.

That probably explains the LLDB [test errors I'm seeing](https://github.com/llvm/llvm-project/issues/77992). I'll try with Python 3.10 see if that solves the issues.

> In general, any probing is really bad for building reproducible packages. I think what we should really do is have the script download the exact Python versions we want.

100% agree. Ideally we should do the same for all the other tools. In all the current/past compagnies I've always tried to make product compile on a clean VM, by pulling on specific versions. We could use `scoop` or `choco` for that purpose?

> But, for local testing it might make sense to bypass this. Maybe there could be another flag for that.

Ok, I can add that.

https://github.com/llvm/llvm-project/pull/78273


More information about the llvm-commits mailing list