[llvm] [MachineFrameInfo] Refactoring with computeMaxcallFrameSize() (NFC) (PR #78001)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 01:58:38 PST 2024


arsenm wrote:

> > This refactoring looks like an improvement to me, but I have one open question and that is regarding global isel as it would also need to set AdjustsStack..?
> 
> You could probably set it in [lowerInlineAsm](https://github.com/llvm/llvm-project/blob/705d9273c5417e04dc542f0e46b90960c235c753/llvm/lib/CodeGen/GlobalISel/InlineAsmLowering.cpp#L215), where the ExtraFlags are computed.
> 
> How is this change going to affect code that doesn't pass through isel? For instance if someone writes a MIR test and doesn't specify `adjustsStack` in the `frameInfo`?

We should teach the verifier to make sure the adjustsStack is consistent with the SP defs in the instruction stream 

https://github.com/llvm/llvm-project/pull/78001


More information about the llvm-commits mailing list