[llvm] [yaml2obj][XOFF] Update yaml2obj for XCOFF to create valid XCOFF files in more cases. (PR #77620)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 16 01:04:02 PST 2024
================
@@ -113,15 +128,10 @@ bool XCOFFWriter::initRelocations(uint64_t &CurrentOffset) {
return true;
}
-bool XCOFFWriter::initSectionHeader(uint64_t &CurrentOffset) {
- uint64_t CurrentSecAddr = 0;
+bool XCOFFWriter::initSectionHeaders(uint64_t &CurrentOffset) {
+ uint64_t CurrentDataAddr = 0;
+ uint64_t CurrentTDataAddr = 0;
----------------
jh7370 wrote:
Nit: these end up being set to the end address, if I'm not mistaken, but their names imply they are the start. I'd suggest renaming to e.g. `CurrentDataEndAddr`.
https://github.com/llvm/llvm-project/pull/77620
More information about the llvm-commits
mailing list