[llvm] [workflows] Split pr-code-format into two parts to make it more secure (PR #78216)

Tobias Hieta via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 23:24:02 PST 2024


================
@@ -44,6 +44,7 @@ class FormatArgs:
     token: str = None
     verbose: bool = True
     issue_number: int = 0
+    write_comment_to_file: bool = False
----------------
tru wrote:

Yeah I think we can remove the dead code, but we can do that in a new commit after this. I don't see any reason to have that in there, we could also just change the code to always write to comment file without the arg.  The change of functionality needs to be documented in the comment of the file, so that if we wan to set this up somewhere else we know what's expected.

https://github.com/llvm/llvm-project/pull/78216


More information about the llvm-commits mailing list