[llvm] [AMDGPU] SILowerSGPRSpills: do not update MRI reserve registers (PR #77888)

Christudasan Devadasan via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 23:09:23 PST 2024


================
@@ -442,12 +440,5 @@ bool SILowerSGPRSpills::runOnMachineFunction(MachineFunction &MF) {
   SaveBlocks.clear();
   RestoreBlocks.clear();
 
-  // Updated the reserved registers with any physical VGPRs added for SGPR
----------------
cdevadas wrote:

The phys VGPRs used for CSR SGPR spilling shouldn't be reused during SIPreAllocateWWMRegs.
I hope they will be marked reserved while getting the AllocationOrder from `RegClassInfo.runOnMachineFunction(MF)` while computing the AllocationOrder.
@arsenm any specific reason they are marked Reserved here explicitly?

https://github.com/llvm/llvm-project/pull/77888


More information about the llvm-commits mailing list