[llvm] [AMDGPU][MC] Remove incorrect `_e32` suffix from `v_dot2c_f32_f16` and `v_dot4c_i32_i8` (PR #77993)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 15 08:01:20 PST 2024
================
@@ -2520,16 +2520,22 @@ multiclass VOP2_Real_DOT_ACC_gfx10<bits<6> op> :
VOP2_Real_dpp_gfx10<op>,
VOP2_Real_dpp8_gfx10<op>;
+multiclass VOP2Only_Real_DOT_ACC_gfx10<bits<6> op> {
+ let IsSingle = 1 in
+ defm NAME : VOP2_Real_e32_gfx10<op>;
+ defm NAME : VOP2_Real_dpp_gfx10<op>, VOP2_Real_dpp8_gfx10<op>;
+}
----------------
jayfoad wrote:
Just FYI I think you could write this as:
```suggestion
multiclass VOP2Only_Real_DOT_ACC_gfx10<bits<6> op> :
VOP2_Real_dpp_gfx10<op>, VOP2_Real_dpp8_gfx10<op> {
let IsSingle = 1 in
defm NAME : VOP2_Real_e32_gfx10<op>;
}
```
I'm not saying it's better; just an alternative to consider.
https://github.com/llvm/llvm-project/pull/77993
More information about the llvm-commits
mailing list