[llvm] [CodeGen][X86] Fix lowering of tailcalls when `-ms-hotpatch` is used (PR #77245)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 06:42:31 PST 2024


sylvain-audi wrote:

> I'm the original reporter to @MolecularMatters about the issue, and I've been running with the Live++ build flags in my project for the past 12 hours with the changes in this PR applied on top of [8fb8ad6](https://github.com/llvm/llvm-project/commit/8fb8ad66c95a51b82e5c2876ed925b5512ce6b83) and it seems to be fine now without needing `-fno-optimize-sibling-calls`

@aganea I think you addressed all my concerns in your latest update.
I tested your change on our game, replacing the workaround we have been using so far, and it worked.
I would think this PR can be merged and that further improvements could probably be kept for separate PRs, but this should probably be validated by a code owner or expert.

https://github.com/llvm/llvm-project/pull/77245


More information about the llvm-commits mailing list