[llvm] [DevPolicy] Add guidance to not submit code or reviews on someone else's (PR #69701)

Kristof Beyls via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 22:49:39 PST 2024


https://github.com/kbeyls updated https://github.com/llvm/llvm-project/pull/69701

>From cfd222df732c8e3e847e5c71554d4c69ab377b49 Mon Sep 17 00:00:00 2001
From: Kristof Beyls <kristof.beyls at llvm.org>
Date: Mon, 9 Oct 2023 18:18:28 +0100
Subject: [PATCH 1/2] [DevPolicy] Add guidance to not submit code or reviews on
 someone else's

... behalf.

There should be few legitimate reasons for people not submitting code or
review comments themselves. Furthermore, it helps avoid situations where
banned individuals circumvent their ban by asking others to submit code
or review comments on their behalf.

More details, see
https://discourse.llvm.org/t/submitting-code-or-review-comments-on-someone-elses-behalf/74269
---
 llvm/docs/DeveloperPolicy.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index f9ac746d006a54..acfedcd44b869a 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -104,6 +104,12 @@ When submitting patches, please do not add confidentiality or non-disclosure
 notices to the patches themselves.  These notices conflict with the LLVM
 licensing terms and may result in your contribution being excluded.
 
+When being asked by someone to add code (e.g. create a PR), or write review
+comments on their behalf, do suggest that they do it directly themselves. Or
+ask the reasons why they're not doing it themselves. There should be few
+legitimate reasons for them not doing so themselves.
+
+
 .. _code review:
 
 Code Reviews

>From 273db042892a5087841c4b880be8bbde3e86cc7f Mon Sep 17 00:00:00 2001
From: Kristof Beyls <kristof.beyls at llvm.org>
Date: Thu, 4 Jan 2024 15:10:56 +0100
Subject: [PATCH 2/2] [DevPolicy] Add guidance on bans

---
 llvm/docs/CodeOfConduct.rst   |  2 ++
 llvm/docs/DeveloperPolicy.rst | 23 ++++++++++++++++++-----
 2 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/llvm/docs/CodeOfConduct.rst b/llvm/docs/CodeOfConduct.rst
index c88c86369382e8..0e986b25df3c86 100644
--- a/llvm/docs/CodeOfConduct.rst
+++ b/llvm/docs/CodeOfConduct.rst
@@ -2,6 +2,8 @@
    This work is licensed under a Creative Commons Attribution 3.0 Unported License.
    SPDX-License-Identifier: CC-BY-3.0
 
+.. _LLVM Community Code of Conduct:
+
 ==============================
 LLVM Community Code of Conduct
 ==============================
diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index acfedcd44b869a..eb6827c2142b26 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -104,11 +104,6 @@ When submitting patches, please do not add confidentiality or non-disclosure
 notices to the patches themselves.  These notices conflict with the LLVM
 licensing terms and may result in your contribution being excluded.
 
-When being asked by someone to add code (e.g. create a PR), or write review
-comments on their behalf, do suggest that they do it directly themselves. Or
-ask the reasons why they're not doing it themselves. There should be few
-legitimate reasons for them not doing so themselves.
-
 
 .. _code review:
 
@@ -640,6 +635,24 @@ attribution mechanism. The previous method was to include "Patch by John Doe."
 in a separate line of the commit message and there are automated processes that
 rely on this format.
 
+Bans
+----
+
+The goal of a ban is to protect people in the community from having to interact
+with people who are consistently not respecting the
+:ref:`LLVM Community Code of Conduct` in LLVM project spaces. Contributions of
+any variety (pull requests, issue reports, forum posts, etc.) require
+interacting with the community. Therefore, we do not accept any form of direct
+contribution from a banned individual.
+
+Indirect contributions are permissible only by someone taking full ownership of
+such a contribution and they are responsible for all related interactions with
+the community regarding that contribution.
+
+When in doubt how to act in a specific instance, please reach out to
+conduct at llvm.org for advice.
+
+
 .. _IR backwards compatibility:
 
 IR Backwards Compatibility



More information about the llvm-commits mailing list