[llvm] [SystemZ][z/OS] yaml2obj GOFF symbols (PR #75971)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 00:59:26 PST 2024


================
@@ -259,6 +313,14 @@ bool GOFFState::writeObject() {
   writeHeader(Doc.Header);
   if (HasError)
     return false;
+  // Iterate over all records.
+  for (auto &Rec : Doc.Records) {
----------------
jh7370 wrote:

As the type of `Records` isn't immediately obvious, I think you shouldn't use `auto` here. Also, should it be `const`? Same goes for the `Sym` type below (`auto` is okay for `Sym` but `const should be added).

https://github.com/llvm/llvm-project/pull/75971


More information about the llvm-commits mailing list