[compiler-rt] Remove maximum OSX version for sanitizers (PR #77543)

Chris Apple via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 14:31:02 PST 2024


cjappl wrote:

> I don't think this is necessarily true. There is 2 issues to consider: building and availability at runtime.

Thanks for the clarity on this point, that makes a lot of sense! I was very surprised to think that these were so "behind" the newer OS.

> For building, if we want to intercept a newly-introduced API we usually "forward declare" the API (copy the minimal set of declarations necessary from the headers) in compiler-rt itself. This enables us to add interceptors for APIs without requiring all builders of compiler-rt to use the new SDK that declares this API.

@yln could you point me to an example of  this? I'm trying to find one for `os_unfair_lock_lock` but can't seem to find the forward declaration in the llvm-project source tree. 

Understanding that will help me........

> ... aligned_alloc not being intercepted is that simply no one has done the work to ensure it works yet. Again, we really appreciate open source contributions in this area.

....do this! Happy to follow up with some PRs to do some of this, I'm in the area.


Lastly:
> On a different note: I am open to bumping the minimal deployment target (even if not strictly necessary) if it eases the maintenance burden.

Let me know if you'd like to see this in this review, or a future one, and what version to move it to. As mentioned in the wall of text there are some deprecation warnings in newer versions while building, but no build errors.




https://github.com/llvm/llvm-project/pull/77543


More information about the llvm-commits mailing list