[llvm] update_test_checks: keep meta variables stable by default (PR #76748)

[Jannik Silvanus via llvm-commits]

Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76748 at github.com>


================
@@ -410,6 +412,42 @@ def should_add_line_to_output(
     return True
 
 
+def collect_original_check_lines(original_check_lines, ti: TestInfo, prefix_set: set):
+    """
+    Collect pre-existing check lines in a the dictionary original_check_lines.
+    original_check_lines[func_name][prefix] is filled with a list of
+    right-hand-sides of check lines.
+    """
+    in_function_start = None
----------------
jasilvanus wrote:

I was confused by naming here -- `in_function_start` is a dict mapping check prefixes to the list of check lines with that prefix for the current function (if relevant).

Why is this called `in_function_start`?

https://github.com/llvm/llvm-project/pull/76748