[llvm] update_test_checks: keep meta variables stable by default (PR #76748)

Jannik Silvanus via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 07:51:29 PST 2024


Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>,
Nicolai =?utf-8?q?Hähnle?= <nicolai.haehnle at amd.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76748 at github.com>


================
@@ -410,6 +412,42 @@ def should_add_line_to_output(
     return True
 
 
+def collect_original_check_lines(original_check_lines, ti: TestInfo, prefix_set: set):
+    """
+    Collect pre-existing check lines in a the dictionary original_check_lines.
----------------
jasilvanus wrote:

Typo: "in a the" -> "into the"

Also, wouldn't it be simpler to return the computed dict?

https://github.com/llvm/llvm-project/pull/76748


More information about the llvm-commits mailing list