[llvm] [SLP]Do not require external uses for roots and single use for other instructions in computeMinimumValueSizes. (PR #72679)

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 07:28:17 PST 2024


================
@@ -13078,10 +13078,13 @@ bool BoUpSLP::collectValuesToDemote(Value *V,
     return true;
   }
 
-  // If the value is not a vectorized instruction in the expression with only
-  // one use, it cannot be demoted.
+  // If the value is not a vectorized instruction in the expression and not the
+  // used by the insertelement instruction, it cannot be demoted.
----------------
RKSimon wrote:


"and not the used by the insertelement instruction" -> "and not used by the insertelement instruction"?

https://github.com/llvm/llvm-project/pull/72679


More information about the llvm-commits mailing list