[llvm] a529b6e - [CodeGen] Fix -Wmismatched-tags in StackProtector.h (NFC)

Jie Fu via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 03:22:28 PST 2024


Author: Jie Fu
Date: 2024-01-09T19:21:43+08:00
New Revision: a529b6eaf05d24518bbe0f0a5539c378252d2671

URL: https://github.com/llvm/llvm-project/commit/a529b6eaf05d24518bbe0f0a5539c378252d2671
DIFF: https://github.com/llvm/llvm-project/commit/a529b6eaf05d24518bbe0f0a5539c378252d2671.diff

LOG: [CodeGen] Fix -Wmismatched-tags in StackProtector.h (NFC)

llvm-project/llvm/include/llvm/CodeGen/StackProtector.h:69:10:
error: class 'AnalysisInfoMixin' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
   69 |   friend class AnalysisInfoMixin<SSPLayoutAnalysis>;
      |          ^
llvm-project/llvm/include/llvm/IR/PassManager.h:414:8: note: previous use is here
  414 | struct AnalysisInfoMixin : PassInfoMixin<DerivedT> {
      |        ^
llvm-project/llvm/include/llvm/CodeGen/StackProtector.h:69:10: note: did you mean struct here?
   69 |   friend class AnalysisInfoMixin<SSPLayoutAnalysis>;
      |          ^~~~~
      |          struct
1 error generated.

Added: 
    

Modified: 
    llvm/include/llvm/CodeGen/StackProtector.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/CodeGen/StackProtector.h b/llvm/include/llvm/CodeGen/StackProtector.h
index 91d0b0d5e304bc..068990f69f2e44 100644
--- a/llvm/include/llvm/CodeGen/StackProtector.h
+++ b/llvm/include/llvm/CodeGen/StackProtector.h
@@ -66,7 +66,7 @@ class SSPLayoutInfo {
 };
 
 class SSPLayoutAnalysis : public AnalysisInfoMixin<SSPLayoutAnalysis> {
-  friend class AnalysisInfoMixin<SSPLayoutAnalysis>;
+  friend struct AnalysisInfoMixin<SSPLayoutAnalysis>;
   using SSPLayoutMap = SSPLayoutInfo::SSPLayoutMap;
 
   static AnalysisKey Key;


        


More information about the llvm-commits mailing list