[lld] [openmp] [polly] [flang] [clang] [libcxx] [compiler-rt] [llvm] [mlir] [libc] [lldb] [WebAssembly] Correctly consider signext/zext arg flags at function declaration (PR #77281)

Andy Wingo via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 01:38:39 PST 2024


================
@@ -839,9 +839,11 @@ bool WebAssemblyFastISel::selectCall(const Instruction *I) {
 
     unsigned Reg;
 
-    if (Attrs.hasParamAttr(I, Attribute::SExt))
+    if (Attrs.hasParamAttr(I, Attribute::SExt) ||
+        (IsDirect && Func->hasParamAttribute(I, Attribute::SExt)))
----------------
wingo wrote:

I have been too long away from LLVM to LGTM, but I would guess that you would have a similar situation with indirect function calls as well.  Perhaps you could test a function that takes a function pointer parameter with sext / zext attributes.  But, again, perhaps this comment is off-base.

https://github.com/llvm/llvm-project/pull/77281


More information about the llvm-commits mailing list