[compiler-rt] [msan] Unwind stack before fatal reports (PR #77168)
Vitaly Buka via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 8 11:30:16 PST 2024
vitalybuka wrote:
> In some functions there is a parameter `*stack` and a variable `stack` in `{}` that shadows the parameter. I wonder whether the variable name for `FATAL` should be changed to reduce confusion...
That's kind of convention for all sanitizers, if we have macro, it create `stack` local object.
I am not rely concerned with shadowing, at it's only for fatal cases, but if you strong about that, I'd rather change parameters in allocator.
https://github.com/llvm/llvm-project/pull/77168
More information about the llvm-commits
mailing list