[llvm] [RISCV] Omit "@plt" in assembler output "call foo at plt" (PR #72467)

Jessica Clarke via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 7 11:42:37 PST 2024


================
@@ -41,8 +41,6 @@ void RISCVMCExpr::printImpl(raw_ostream &OS, const MCAsmInfo *MAI) const {
   if (HasVariant)
     OS << '%' << getVariantKindName(getKind()) << '(';
   Expr->print(OS, MAI);
-  if (Kind == VK_RISCV_CALL_PLT)
-    OS << "@plt";
----------------
jrtc27 wrote:

After chatting out of band, I hadn't appreciated GNU as assembles `call foo` to use R_RISCV_CALL_PLT these days (https://github.com/bminor/binutils-gdb/commit/70f35d72ef04cd23771875c1661c9975044a749c), so this is no longer a concern to me. The only broken situation would be using an old (pre-2.40, or >1y) binutils, but that's probably broken for other reasons already.

https://github.com/llvm/llvm-project/pull/72467


More information about the llvm-commits mailing list