[llvm] [GitHub] Add python 3.7 to libclang python test (PR #77219)

Craig Hesling via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 6 19:18:26 PST 2024


================
@@ -30,10 +30,15 @@ jobs:
   check-clang-python:
     # Build libclang and then run the libclang Python binding's unit tests.
     name: Build and run Python unit tests
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.7", "3.11"]
----------------
linux4life798 wrote:

Yeah, if we need to lock in an old version of Python, version 3.7 seems like the best bang for your buck for python type annotation features. Plus that still covers Debian old old stable ([Debian buster](https://wiki.debian.org/Python#Supported_Python_Versions)). Version 3.6 restricts the annotation in a way that would go against most python type annotations best practices.

Honestly, I think 3.8 would be better, since that gets you the python `Literal` type, but it doesn't seem like [RFC Upgrading LLVM’s minimum required Python version](https://discourse.llvm.org/t/rfc-upgrading-llvms-minimum-required-python-version/67571) was going anywhere. It is also worth noting that there are instances of new features being used in other python file in LLVM. I just think no one is testing against 3.6?

I explained the rationale and feature breakdown in the first two comments of https://github.com/llvm/llvm-project/issues/76664.



https://github.com/llvm/llvm-project/pull/77219


More information about the llvm-commits mailing list