[llvm] [DWARFLinker] Support MD5 checksums in the line table (PR #77151)

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 16:54:15 PST 2024


================
@@ -859,18 +859,20 @@ void DwarfStreamer::emitLineTablePrologueV5IncludeAndFileTable(
   for (auto Include : P.IncludeDirectories)
     emitLineTableString(P, Include, DebugStrPool, DebugLineStrPool);
 
-  bool InlineSources = any_of(P.FileNames, [](auto &File) {
-    auto s = dwarf::toString(File.Source);
-    return s && !**s;
-  });
+  bool HasChecksums = P.ContentTypes.HasMD5;
+  bool HasInlineSources =
+      P.ContentTypes.HasSource && any_of(P.FileNames, [](auto &File) {
----------------
JDevlieghere wrote:

I wanted to double check the semantics, but yeah I think you're right. I was considering the optimization of actually checking that there's meaningful source code embedded there, but as I write it out I've pretty much convinced myself that's just making things complicated for barely/no gain. 

https://github.com/llvm/llvm-project/pull/77151


More information about the llvm-commits mailing list