[llvm] [llvm-objdump] Add support for symbolizing PGOBBAddrMap Info (PR #76386)
Micah Weston via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 5 13:36:25 PST 2024
================
@@ -1264,23 +1264,70 @@ static SymbolInfoTy createDummySymbolInfo(const ObjectFile &Obj,
return SymbolInfoTy(Addr, Name, Type);
}
-static void
-collectBBAddrMapLabels(const std::unordered_map<uint64_t, BBAddrMap> &AddrToBBAddrMap,
- uint64_t SectionAddr, uint64_t Start, uint64_t End,
- std::unordered_map<uint64_t, std::vector<std::string>> &Labels) {
+static void collectBBAddrMapLabels(
+ const std::unordered_map<uint64_t, BBAddrMap> &AddrToBBAddrMap,
+ const std::unordered_map<uint64_t, PGOAnalysisMap> &AddrToPGOBBAddrMap,
+ uint64_t SectionAddr, uint64_t Start, uint64_t End,
+ std::unordered_map<
+ uint64_t, std::vector<std::pair<std::string, std::string>>> &Labels) {
----------------
red1bluelost wrote:
Please define a 'plain-old-data' `struct` so it is clear what parts of the pair mean. Also helps if in the future we want to add new label parts.
```c++
struct BBAddrMapLabel {
std::string BlockLabel;
std::string PGOAnalysis;
}
```
https://github.com/llvm/llvm-project/pull/76386
More information about the llvm-commits
mailing list