[lld] [lld] [MTE] Allow android note for static executables. (PR #77078)

Florian Mayer via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 10:41:35 PST 2024


================
@@ -397,11 +401,13 @@ template <class ELFT> void elf::createSyntheticSections() {
         std::make_unique<SymbolTableSection<ELFT>>(*part.dynStrTab);
     part.dynamic = std::make_unique<DynamicSection<ELFT>>();
 
-    if (canHaveMemtagGlobals()) {
+    if (hasMemtag()) {
       part.memtagAndroidNote = std::make_unique<MemtagAndroidNote>();
       add(*part.memtagAndroidNote);
-      part.memtagDescriptors = std::make_unique<MemtagDescriptors>();
-      add(*part.memtagDescriptors);
+      if (canHaveMemtagGlobals()) {
+        part.memtagDescriptors = std::make_unique<MemtagDescriptors>();
----------------
fmayer wrote:

driveby, potentially in another CL: can we rename `MemtagDescriptors` to `MemtagGlobalDescriptors`?

https://github.com/llvm/llvm-project/pull/77078


More information about the llvm-commits mailing list