[llvm] [lld] [compiler-rt] [InstrProf] No linkage prefixes in IRPGO names (PR #76994)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 15:17:52 PST 2024


================
@@ -330,7 +303,17 @@ static std::optional<std::string> lookupPGONameFromMetadata(MDNode *MD) {
   return {};
 }
 
-// Returns the PGO object name. This function has some special handling
+// The PGO name has the format [<filepath>;]<function-name> where <filepath>; is
----------------
minglotus-6 wrote:

> Where is getIRPGOObjectName() called on a global variable? 

It's only called on functions in top-of-the-tree. To add [type-profiling](https://discourse.llvm.org/t/rfc-dynamic-type-profiling-and-optimizations-in-llvm/74600/9) in instrFDO, a [pending pull request](https://github.com/llvm/llvm-project/pull/66825) will use it on virtual table definitions. This is the motivation for [pull request 70287](https://github.com/llvm/llvm-project/pull/70287) to refactor the function names and arguments (to take `GlobalObjects`).

https://github.com/llvm/llvm-project/pull/76994


More information about the llvm-commits mailing list