[llvm] [AMDGPU][GlobalISel] Update tests to check for COV5 (PR #76257)

Saiyedul Islam via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 04:23:40 PST 2024


saiislam wrote:

> Ideally we prefer the LIT tests not to specify module flag of code object version. The exceptions are to check the features related to particular code object version. This is to say for the tests to check unrelated issues (unrelated to particular cov), it is better just to keep just one copy of the test with default code object version. When you specify cov5, it essentially stops a test for future code object version. Would you please double check whether these tests are for the feature of cov5 only? (not useful/valid for other covs), Thanks.

Yes, I agree that this modified behavior only checks for cov5. But, it has been done to test cov5 more thoroughly and reduce the churn in the patch to make cov5 default. Once the switch has happened, we can remove the IR changes as suggested by @arsenm.

https://github.com/llvm/llvm-project/pull/76257


More information about the llvm-commits mailing list