[llvm] [GlobalIsel] Combine select of binops (PR #76763)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 3 00:01:49 PST 2024
================
@@ -6548,6 +6534,52 @@ bool CombinerHelper::tryFoldBoolSelectToLogic(GSelect *Select,
return false;
}
+bool CombinerHelper::tryFoldSelectOfBinOps(GSelect *Select,
+ BuildFnTy &MatchInfo) {
+ Register DstReg = Select->getReg(0);
+ Register Cond = Select->getCondReg();
+ Register False = Select->getFalseReg();
+ Register True = Select->getTrueReg();
+ LLT DstTy = MRI.getType(DstReg);
+
+ GBinOp *LHS = getOpcodeDef<GBinOp>(True, MRI);
+ GBinOp *RHS = getOpcodeDef<GBinOp>(False, MRI);
+
+ // We need two binops of the same kind on the true/false registers.
+ if (!LHS || !RHS || LHS->getOpcode() != RHS->getOpcode())
+ return false;
+
+ // Note that there are no constraints on CondTy.
+ unsigned Flags = LHS->getFlags() & RHS->getFlags();
----------------
arsenm wrote:
That's also suboptimal for the DAG combiner. I think it should be (LHS & RHS) | Select. Does InstCombine preserve these?
https://github.com/llvm/llvm-project/pull/76763
More information about the llvm-commits
mailing list