[llvm] a22c8ef - [MC,test] Merge register-assignment-error.s into register-assignment.s and improve the test

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2023-12-28T19:45:37-08:00
New Revision: a22c8efad733cf3407a93387a6a9c743659dc74c

URL: https://github.com/llvm/llvm-project/commit/a22c8efad733cf3407a93387a6a9c743659dc74c
DIFF: https://github.com/llvm/llvm-project/commit/a22c8efad733cf3407a93387a6a9c743659dc74c.diff

LOG: [MC,test] Merge register-assignment-error.s into register-assignment.s and improve the test

To actually address my review comment in #75693

Added: 
    

Modified: 
    llvm/test/MC/X86/register-assignment.s

Removed: 
    llvm/test/MC/X86/register-assignment-error.s


################################################################################
diff  --git a/llvm/test/MC/X86/register-assignment-error.s b/llvm/test/MC/X86/register-assignment-error.s
deleted file mode 100644
index 6c5fcf3cae9e1f..00000000000000
--- a/llvm/test/MC/X86/register-assignment-error.s
+++ /dev/null
@@ -1,8 +0,0 @@
-// RUN: not llvm-mc -triple x86_64 %s -o /dev/null 2>&1 | FileCheck %s
-
-var_xdata = %rcx
-
-// This used to crash.
-.if var_xdata == 1
-.endif
-// CHECK: error: expected absolute expression
\ No newline at end of file

diff  --git a/llvm/test/MC/X86/register-assignment.s b/llvm/test/MC/X86/register-assignment.s
index 84ea062cb746e5..4c7b07df050b88 100644
--- a/llvm/test/MC/X86/register-assignment.s
+++ b/llvm/test/MC/X86/register-assignment.s
@@ -1,4 +1,5 @@
 // RUN: llvm-mc -triple x86_64-unknown-unknown %s -o -      | FileCheck %s
+// RUN: not llvm-mc -triple x86_64 --defsym ERR=1 %s -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR
 	
 // CHECK-NOT: .set var_xdata
 var_xdata = %rcx
@@ -25,3 +26,12 @@ xorq var_xdata, var_xdata
 .else
   .byte 2
 .endif
+
+.ifdef ERR
+// ERR: [[#@LINE+1]]:5: error: expected absolute expression
+.if var_xdata == 1
+.endif
+// ERR: [[#@LINE+1]]:5: error: expected absolute expression
+.if 1 == var_xdata
+.endif
+.endif