[llvm] [TLI] replace-with-veclib works with FRem Instruction. (PR #76166)

Maciej Gabka via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 08:16:18 PST 2023


================
@@ -69,52 +69,57 @@ Function *getTLIFunction(Module *M, FunctionType *VectorFTy,
   return TLIFunc;
 }
 
-/// Replace the call to the vector intrinsic ( \p CalltoReplace ) with a call to
-/// the corresponding function from the vector library ( \p TLIVecFunc ).
-static void replaceWithTLIFunction(CallInst &CalltoReplace, VFInfo &Info,
+/// Replace the Instruction \p I, that may be a vector intrinsic CallInst or
----------------
mgabka wrote:

I think you overcomplicated this comment.
Could you change it to:

"Replace the Instruction \p I with a call to the corresponding function from the vector library ( \p TLIVecFunc )."

there is no dedicated logic to frem inside this function so there is no point to mention it in a comment.

https://github.com/llvm/llvm-project/pull/76166


More information about the llvm-commits mailing list