[llvm] Attempt to install and upload results of libc++ build in C++26 configuration. (PR #76235)

via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 05:39:57 PST 2023


https://github.com/EricWF updated https://github.com/llvm/llvm-project/pull/76235

>From 6a777ac6ab0303a6ee6ceb754e0c8814c1ae973e Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Fri, 22 Dec 2023 08:36:36 -0500
Subject: [PATCH 1/2] Attempt to install and upload results of libc++ build in
 C++26 configuration.

The idea is to make these artifacts accessible elsewhere, for easier
analysis of pull requests.
---
 .github/workflows/libcxx-build-and-test.yaml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 25e8c8c1ef21aa..2133d74a086db6 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -86,6 +86,17 @@ jobs:
             **/CMakeError.log
             **/CMakeOutput.log
             **/crash_diagnostics/*
+      # Install the artifacts for to a dummy directory and capture them as artifacts to be downloaded and consumed
+      # elsewhere.
+      - name: install-artifacts
+        run: |
+          cmake --build build/{{matrix.config}} -- install
+      - uses: actions/upload-artifact at v3
+        if: {{ matrix.config == 'generic-cxx26'}}  # Upload artifacts even if the build or test suite fails
+        with:
+          name: ${{ matrix.config }}-installation
+          path: |
+            build/{{matrix.config}}/install
   stage2:
     if: github.repository_owner == 'llvm'
     runs-on: libcxx-runners-8-set
@@ -135,6 +146,7 @@ jobs:
             **/CMakeError.log
             **/CMakeOutput.log
             **/crash_diagnostics/*
+
   stage3:
     if: github.repository_owner == 'llvm'
     needs: [ stage1, stage2 ]

>From cc867fdfa1c24ee25bb0dca683a4e12a7c3d5028 Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Fri, 22 Dec 2023 08:39:46 -0500
Subject: [PATCH 2/2] attempt to fix yaml

---
 .github/workflows/libcxx-build-and-test.yaml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 2133d74a086db6..e6078ee9802eef 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -90,13 +90,14 @@ jobs:
       # elsewhere.
       - name: install-artifacts
         run: |
-          cmake --build build/{{matrix.config}} -- install
-      - uses: actions/upload-artifact at v3
-        if: {{ matrix.config == 'generic-cxx26'}}  # Upload artifacts even if the build or test suite fails
+          cmake --build build/${{matrix.config}} -- install
+      - name: upload-installation
+        if: matrix.config == 'generic-cxx26'  # Upload artifacts even if the build or test suite fails
+        uses: actions/upload-artifact at v3
         with:
           name: ${{ matrix.config }}-installation
           path: |
-            build/{{matrix.config}}/install
+            build/${{matrix.config}}/install
   stage2:
     if: github.repository_owner == 'llvm'
     runs-on: libcxx-runners-8-set



More information about the llvm-commits mailing list