[llvm] [LoopVectorize] Refine runtime memory check costs when there is an outer loop (PR #76034)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 22 04:00:22 PST 2023
================
@@ -2091,16 +2091,45 @@ class GeneratedRTChecks {
LLVM_DEBUG(dbgs() << " " << C << " for " << I << "\n");
RTCheckCost += C;
}
- if (MemCheckBlock)
+ if (MemCheckBlock) {
+ InstructionCost MemCheckCost = 0;
for (Instruction &I : *MemCheckBlock) {
if (MemCheckBlock->getTerminator() == &I)
continue;
InstructionCost C =
TTI->getInstructionCost(&I, TTI::TCK_RecipThroughput);
LLVM_DEBUG(dbgs() << " " << C << " for " << I << "\n");
- RTCheckCost += C;
+ MemCheckCost += C;
+ }
+
+ // If the runtime memory checks are being created inside an outer loop
+ // we should find out if these checks are outer loop invariant. If so,
+ // the checks will be hoisted out and so the effective cost will reduce
+ // according to the outer loop trip count.
+ if (OuterLoop) {
+ ScalarEvolution *SE = MemCheckExp.getSE();
+ const SCEV *Cond = SE->getSCEV(MemRuntimeCheckCond);
----------------
fhahn wrote:
Is it possible to have a mixture of invariant/variant checks or at least some invariant instructions generated? If so, it would probably be more accurate to check for each generated instruction?
https://github.com/llvm/llvm-project/pull/76034
More information about the llvm-commits
mailing list