[llvm] Allow the dumping of .dwo files contents to show up when dumping an e… (PR #66726)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 09:34:46 PST 2023


================
@@ -751,7 +751,7 @@ void DWARFUnit::updateAddressDieMap(DWARFDie Die) {
 DWARFDie DWARFUnit::getSubroutineForAddress(uint64_t Address) {
   extractDIEsIfNeeded(false);
   if (AddrDieMap.empty())
-    updateAddressDieMap(getUnitDIE());
+    updateAddressDieMap(getNonSkeletonUnitDIE(/*ExtractUnitDIEOnly=*/false));
----------------
dwblaikie wrote:

I'd err on the side of not searching all the dwos without opting in, since it might be quite expensive/a lot of results or things to search through. In any case, seems best to discuss in a separate review, perhaps.

I worry about whether this codepath affects symbolizing in some way, for instance (which the inline info in the skeleton is meant to help with/avoid having to parse the dwos). Separate patches will let us track regressions more carefully.

https://github.com/llvm/llvm-project/pull/66726


More information about the llvm-commits mailing list