[llvm] [llvm-objcopy] Support SREC output format (PR #75874)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 19 00:29:44 PST 2023
https://github.com/jh7370 commented:
Thank you for your contribution! This is a very large patch, and I won't have time to review it until the new year. In the meantime, some high-level comments:
1) Please make sure to update the llvm-objcopy documentation. You can find it at llvm/docs/CommandGuide/llvm-objcopy.rst.
2) I assume you have a need for this functionality in your company/team/...? We don't generally accept patches for new functionality if there is no concrete use case.
3) It may be better to split this into a sequence of PRs, which incrementally add the functionality, rather than trying to add it all at once. For example, is it possible to support an empty ELF file with no sections/symbols/relocations/program headers in a first patch, and then add support for different section types etc in follow-on PRs?
https://github.com/llvm/llvm-project/pull/75874
More information about the llvm-commits
mailing list