[llvm] Allow the dumping of .dwo files contents to show up when dumping an e… (PR #66726)

via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 21:35:57 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 06b2da4155a6bd88747307c108536a957d0f1daa e664c09a29389d3c1800c37b943f0a5d277a1e56 -- llvm/include/llvm/DebugInfo/DIContext.h llvm/lib/DebugInfo/DWARF/DWARFCompileUnit.cpp llvm/lib/DebugInfo/DWARF/DWARFContext.cpp llvm/lib/DebugInfo/DWARF/DWARFUnit.cpp llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp b/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
index 97cb303d92..38d21f1c8a 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
@@ -1030,9 +1030,9 @@ void DWARFContext::dump(
         DWARFDie CUDie = U->getUnitDIE(false);
         DWARFDie CUNonSkeletonDie = U->getNonSkeletonUnitDIE(false);
         if (CUNonSkeletonDie && CUDie != CUNonSkeletonDie) {
-          CUNonSkeletonDie.getDwarfUnit()->getDIEForOffset(*DumpOffset)
+          CUNonSkeletonDie.getDwarfUnit()
+              ->getDIEForOffset(*DumpOffset)
               .dump(OS, 0, DumpOpts.noImplicitRecursion());
-
         }
       }
     else
diff --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 6a633ea9f2..1decb5f7a0 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -407,7 +407,6 @@ static void filterByName(
       if (const char *Name = Die.getName(DINameKind::LinkageName))
         filterByName(Names, Die, Name, OS, GetNameForDWARFReg);
     }
-
   };
   for (const auto &CU : CUs) {
     filterDieNames(CU.get());

``````````

</details>


https://github.com/llvm/llvm-project/pull/66726


More information about the llvm-commits mailing list