[compiler-rt] [compiler-rt]Mark test as unsupported before fixing all the mangled names on Windows (PR #75886)

Mingming Liu via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 18:58:24 PST 2023


https://github.com/minglotus-6 created https://github.com/llvm/llvm-project/pull/75886

The compiler-rt test fails on Windows due to mismatched names (https://lab.llvm.org/buildbot/#/builders/127/builds/59907/steps/8/logs/stdio)
- Given there are name matchers on many lines, mark the test as unsupported on Windows 64-bit for now. Need to get a machine to fix all the names. 

>From 8ba186921f15248ec48bc90540006f7237ecf3ec Mon Sep 17 00:00:00 2001
From: mingmingl <mingmingl at google.com>
Date: Mon, 18 Dec 2023 18:56:21 -0800
Subject: [PATCH] [compiler-rt]Mark test as unsupported before fixing all the
 mangled names on Windows

---
 .../instrprof-thinlto-indirect-call-promotion.cpp      | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
index 82ca1cd7d0a564..85b624c8dbed04 100644
--- a/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
+++ b/compiler-rt/test/profile/instrprof-thinlto-indirect-call-promotion.cpp
@@ -23,13 +23,9 @@
 //
 // XFAIL: system-darwin
 //
-// Mark 32-bit Windows as UNSUPPORTED for now as opposed to XFAIL. This test
-// should fail on many (but not all) 32-bit Windows systems and succeed on the
-// rest. The flexibility in triple string parsing makes it tricky to capture
-// both sets accurately. i[3-9]86 specifies arch as Triple::ArchType::x86, (win32|windows)
-// specifies OS as Triple::OS::Win32
-//
-// UNSUPPORTED: target={{i.86.*windows.*}}
+// FIXME: Fix mangled name matcher on Windows and re-enable test on 64-bit
+// windows.
+// UNSUPPORTED: windows
 
 // RUN: rm -rf %t && split-file %s %t && cd %t
 



More information about the llvm-commits mailing list