[llvm] [CodeGen] This patch fix a bug that may caused error for a self-defined target in SelectionDAG::getNode (PR #75320)

[yan zhou via llvm-commits]

https://github.com/zhou3968322 updated https://github.com/llvm/llvm-project/pull/75320

>From c07f90877af058267c16d37501c8602af4470a00 Mon Sep 17 00:00:00 2001
From: yan zhou <42528857+zhou3968322 at users.noreply.github.com>
Date: Wed, 13 Dec 2023 19:09:03 +0800
Subject: [PATCH 1/2] fix a bug that may caused self-defined target.

first judage N1.getNumOperands() > 0 may be better.

If Lowering Generated SDNode like.

v2i32 t20:  TargetOpNode.
i32 t21: extract_vector_elt t20 0.

will cause a error.
---
 llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 5be1892a44f6dd..20a2791dc263e2 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6858,8 +6858,8 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
     // expanding copies of large vectors from registers. This only works for
     // fixed length vectors, since we need to know the exact number of
     // elements.
-    if (N2C && N1.getOperand(0).getValueType().isFixedLengthVector() &&
-        N1.getOpcode() == ISD::CONCAT_VECTORS && N1.getNumOperands() > 0) {
+    if (N2C &&  N1.getOpcode() == ISD::CONCAT_VECTORS
+        N1.getOperand(0).getValueType().isFixedLengthVector()) {
       unsigned Factor =
         N1.getOperand(0).getValueType().getVectorNumElements();
       return getNode(ISD::EXTRACT_VECTOR_ELT, DL, VT,
@@ -6976,7 +6976,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
 
     // EXTRACT_SUBVECTOR of CONCAT_VECTOR can be simplified if the pieces of
     // the concat have the same type as the extract.
-    if (N1.getOpcode() == ISD::CONCAT_VECTORS && N1.getNumOperands() > 0 &&
+    if (N1.getOpcode() == ISD::CONCAT_VECTORS &&
         VT == N1.getOperand(0).getValueType()) {
       unsigned Factor = VT.getVectorMinNumElements();
       return N1.getOperand(N2C->getZExtValue() / Factor);

>From f919c46b6cc376fae57443b287f9b2ddc37d29d4 Mon Sep 17 00:00:00 2001
From: yanzhou <zhou3968322 at qq.com>
Date: Tue, 19 Dec 2023 10:45:45 +0800
Subject: [PATCH 2/2] fix bug

---
 llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 20a2791dc263e2..45067dfbdb96ff 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6858,7 +6858,7 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
     // expanding copies of large vectors from registers. This only works for
     // fixed length vectors, since we need to know the exact number of
     // elements.
-    if (N2C &&  N1.getOpcode() == ISD::CONCAT_VECTORS
+    if (N2C &&  N1.getOpcode() == ISD::CONCAT_VECTORS &&
         N1.getOperand(0).getValueType().isFixedLengthVector()) {
       unsigned Factor =
         N1.getOperand(0).getValueType().getVectorNumElements();