[compiler-rt] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 17:57:35 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-pgo

Author: Mingming Liu (minglotus-6)

<details>
<summary>Changes</summary>

Tested by `ninja check-profile` and all tests pass on a mac laptop.

---
Full diff: https://github.com/llvm/llvm-project/pull/75884.diff


1 Files Affected:

- (modified) compiler-rt/test/profile/CMakeLists.txt (+1-1) 


``````````diff
diff --git a/compiler-rt/test/profile/CMakeLists.txt b/compiler-rt/test/profile/CMakeLists.txt
index 975e4c42f4b640..3057abebbe52cf 100644
--- a/compiler-rt/test/profile/CMakeLists.txt
+++ b/compiler-rt/test/profile/CMakeLists.txt
@@ -7,7 +7,7 @@ set(PROFILE_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS} compiler-rt-headers)
 list(APPEND PROFILE_TEST_DEPS profile)
 if(NOT COMPILER_RT_STANDALONE_BUILD)
   list(APPEND PROFILE_TEST_DEPS llvm-profdata llvm-cov)
-  if(NOT APPLE AND COMPILER_RT_HAS_LLD AND "lld" IN_LIST LLVM_ENABLE_PROJECTS)
+  if(COMPILER_RT_HAS_LLD AND "lld" IN_LIST LLVM_ENABLE_PROJECTS)
     list(APPEND PROFILE_TEST_DEPS lld)
   endif()
 endif()

``````````

</details>


https://github.com/llvm/llvm-project/pull/75884


More information about the llvm-commits mailing list